[igt-dev] [PATCH i-g-t] README: Mention Dockerfiles with dependencies by name

Petri Latvala petri.latvala at intel.com
Tue Oct 15 11:16:20 UTC 2019


On Tue, Oct 15, 2019 at 02:13:01PM +0300, Arkadiusz Hiler wrote:
> Debian has two Dockerfiles associated - minimal and regular one that
> bases on the minimal one.
> 
> Let's mention them by name and add a comment providing some context to
> the split so it's easier to figure out what to install on a new system.
> 
> Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler at intel.com>

Reviewed-by: Petri Latvala <petri.latvala at intel.com>


> ---
>  Dockerfile.build-debian | 5 +++++
>  README.md               | 4 ++--
>  2 files changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/Dockerfile.build-debian b/Dockerfile.build-debian
> index 69f63157..36c51765 100644
> --- a/Dockerfile.build-debian
> +++ b/Dockerfile.build-debian
> @@ -2,6 +2,11 @@ ARG CI_COMMIT_SHA
>  ARG CI_REGISTRY_IMAGE
>  FROM $CI_REGISTRY_IMAGE/build-debian-minimal:commit-$CI_COMMIT_SHA
>  
> +# inherits from Dockerfile.build-debian-minimal
> +#
> +# just few extra dependencies for building IGT with all the optional components
> +# enabled
> +
>  RUN apt-get update
>  RUN apt-get install -y \
>  			libunwind-dev \
> diff --git a/README.md b/README.md
> index a6a821c0..f33e9455 100644
> --- a/README.md
> +++ b/README.md
> @@ -20,8 +20,8 @@ Generated documentation for the latest master is published under
>  Requirements
>  ------------
>  
> -See `Dockerfile.*` for up-to-date list of package names in Fedora and
> -Debian.
> +See `Dockerfile.build-fedora` for up-to-date list of package names in Fedora
> +or `Dockerfile.build-debian-minimal` and `Dockerfile.build-debian` for Debian.
>  
>  If your distribution packages IGT you can also use your package manager to
>  install the dependencies, e.g.:
> -- 
> 2.21.0
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev


More information about the igt-dev mailing list