[igt-dev] ✗ Fi.CI.BAT: failure for removal of igt_skip_on_simulation() from i915/ tests

[Arkadiusz Hiler]

On Wed, Oct 16, 2019 at 01:53:25PM +0300, Petri Latvala wrote:
> On Wed, Oct 16, 2019 at 09:55:29AM +0000, Patchwork wrote:
> > == Series Details ==
> > 
> > Series: removal of igt_skip_on_simulation() from i915/ tests
> > URL   : https://patchwork.freedesktop.org/series/68073/
> > State : failure
> > 
> > == Summary ==
> > 
> > CI Bug Log - changes from CI_DRM_7104 -> IGTPW_3575
> > ====================================================
> > 
> > Summary
> > -------
> > 
> >   **FAILURE**
> > 
> >   Serious unknown changes coming with IGTPW_3575 absolutely need to be
> >   verified manually.
> >   
> >   If you think the reported changes have nothing to do with the changes
> >   introduced in IGTPW_3575, please notify your bug team to allow them
> >   to document this new failure mode, which will reduce false positives in CI.
> > 
> >   External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3575/index.html
> > 
> > Possible new issues
> > -------------------
> > 
> >   Here are the unknown changes that may have been introduced in IGTPW_3575:
> > 
> > ### IGT changes ###
> > 
> > #### Possible regressions ####
> > 
> >   * igt at gem_render_linear_blits@basic:
> >     - fi-cml-u:           [PASS][1] -> [CRASH][2] +1 similar issue
> >    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7104/fi-cml-u/igt@gem_render_linear_blits@basic.html
> >    [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3575/fi-cml-u/igt@gem_render_linear_blits@basic.html
> > 
> >   * igt at gem_render_tiled_blits@basic:
> >     - fi-cml-u2:          [PASS][3] -> [CRASH][4] +1 similar issue
> >    [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7104/fi-cml-u2/igt@gem_render_tiled_blits@basic.html
> >    [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3575/fi-cml-u2/igt@gem_render_tiled_blits@basic.html
> 
> 
> Wrong libdrm. Arek, is it broken 1) again, or 2) still?

3) other

Turns out there was a stray conditional "make install" happening
outside of normal building path, which is just used for "FAST"
build, i.e. pre-merge.

This was not altered, which affected pre-merge.

I have changed the flow to be more like:

if $POSTMERGE; then
  git -C libdrm pull
  (cd libdrm; meson build && ninja -C build)
  report_errors_if_failed $?
fi

ninja -C libdrm/build install
report_errors_if_failed $?

I have queued a rerun. Thanks for noticing!

-- 
Cheers,
Arek