[igt-dev] [PATCH i-g-t 3/3] tests/kms_tiled_display: Get rid of DP stuff

[Manasi Navare]

On Tue, Oct 15, 2019 at 03:27:13PM +0300, Ville Syrjälä wrote:
> On Mon, Oct 14, 2019 at 01:58:58PM -0700, Manasi Navare wrote:
> > On Mon, Oct 14, 2019 at 11:21:22PM +0300, Ville Syrjälä wrote:
> > > On Mon, Oct 14, 2019 at 12:57:33PM -0700, Manasi Navare wrote:
> > > > On Mon, Oct 14, 2019 at 09:13:15PM +0300, Ville Syrjala wrote:
> > > > > From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> > > > > 
> > > > > There is nothing DP specific about the tile property. So
> > > > > remove any mention of DP (and port sync which is an i915
> > > > > hardware feature). Let's just talk about genlocked CRTCs
> > > > > and tiled connectors, which is pretty generic.
> > > > 
> > > > But we currently dont support the trans port sync feature for other
> > > > connectorrs other than DP so the test will fail so IMO, 
> > > > currently it should only run for DP tiled connectors
> > > 
> > > That's an i915 specific limitation and if you want to check for that
> > > then the check should be written as 'if (is_i915 && whatever)'.
> > > 
> > > > 
> > > > even DP MST trans port sync might fail havent added this to MST yet
> > > 
> > > Right, so the check isn't correct even on i915 -> better to just nuke it.
> > >
> > 
> > So would you modify this patch to add those checks or would that be a follow up patch?
> 
> I still don't see the point of adding any checks. The test will just
> fail if the crtcs aren't genlocked, which is totally fine.

Okay sure that makes sense then, it will help catching the issues where
there are corruption issues if crtcs not genlocked

With that then:

Reviewed-by: Manasi Navare <manasi.d.navare at intel.com>

manasi

> 
> -- 
> Ville Syrjälä
> Intel