[igt-dev] [PATCH i-g-t 2/2] tests/gem_exec_reloc: Calculate softpin offsets from batch size

[Katarzyna Dec]

On Wed, Oct 23, 2019 at 10:13:02AM +0100, Chris Wilson wrote:
> Quoting Janusz Krzysztofik (2019-10-23 10:07:52)
> > From: Janusz Krzysztofik <janusz.krzysztofik at intel.com>
> > 
> > The basic-range subtest assumes 4kB minimum batch size.  On future
> > backends with possibly bigger minimum batch sizes this subtest will
> > fail as buffer objects may overlap.  To avoid object overlapping,
> > offsets need to be calculated with actual minimum batch size in mind.
> > 
> > Replace hardcoded constants corresponding to the assumed 4kB minimum
> > batch size with values calculated from a variable supposed to represent
> > actual batch size.  For now, the variable is still initialized with the
> > 4kB value, suitable for backends currently supported by IGT.
> 
> You could do this entirely within the reloc API, no? By probing whether
> a 4KiB offset is legal?
> -Chris

Chris - you meant - add such checking to library in IGT or move such checking
into kernel code?
If any of this above - than I am also for making more global adjustments. What if other tests
would reqire such change? Will we be fixing every binary?

Kasia