[igt-dev] [PATCH i-g-t 4/8] runner: Parse dynamic subtest outputs and results

Arkadiusz Hiler arkadiusz.hiler at intel.com
Fri Oct 25 11:03:25 UTC 2019


On Thu, Oct 24, 2019 at 02:05:42PM +0300, Petri Latvala wrote:
> If binary 'bin' has a subtest 'sub', which has dynamic subtests 'foo'
> and 'bar', results.json will now have "subtests" by the names
> igt at bin@sub at foo and igt at bin@sub at bar, with data as expected of normal
> subtests.
> 
> Signed-off-by: Petri Latvala <petri.latvala at intel.com>

Those fill_from_ functions are monstrous... Each time I review changes
there I have to read through the full code on the side first to get
what's going on, and it's still easy to get lost.

Next time we are touching this area it should undergo a modernization...

Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler at intel.com>


More information about the igt-dev mailing list