[igt-dev] [PATCH i-g-t] .gitlab-ci: List test binaries with missing top-level description correctly

Arkadiusz Hiler arkadiusz.hiler at intel.com
Wed Sep 4 13:39:45 UTC 2019


Boolean logic with string is hard.

Cc: Petri Latvala <petri.latvala at intel.com>
Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler at intel.com>
---
 .gitlab-ci/list_undocumented_tests.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/.gitlab-ci/list_undocumented_tests.py b/.gitlab-ci/list_undocumented_tests.py
index ee836559..0ce3f330 100755
--- a/.gitlab-ci/list_undocumented_tests.py
+++ b/.gitlab-ci/list_undocumented_tests.py
@@ -47,12 +47,12 @@ def main():
     for test in tests:
         subtests = get_subtests(testdir, test)
 
-        if subtests and subtests[0].name:
-            # no top level description
+        if subtests and subtests[0].name is None:
+            # top level description missing, list binary
             print(test)
 
         for name, description in subtests:
-            if not name:
+            if name is None: # top level description, skipping
                 continue
 
             if "NO DOCUMENTATION!" in description:
-- 
2.21.0



More information about the igt-dev mailing list