[igt-dev] [PATCH i-g-t] lib/kmod: reimplement kmsg_dump()

Lucas De Marchi lucas.demarchi at intel.com
Fri Sep 27 20:24:20 UTC 2019


On Fri, Sep 27, 2019 at 09:09:50PM +0100, Chris Wilson wrote:
>Quoting Lucas De Marchi (2019-09-20 02:07:23)
>> Now the line in (1) print as:
>>         (i915_selftest:5070) igt_kmod-WARNING: [drm:intel_pch_type [i915]] Found Tiger Lake LP PCH

...

>>
>> This also fixes a double close on fclose() already closes the file
>> descriptor.
>>
>> Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>
>
>Too bad it doesn't actually work and bails on the first read with EPIPE.

humn... I copy-pasted the line above.

Checking printk.c it will happen if we explode the ringbuffer with log messages
before actually reading them. You may want to increase the buffer size
to get them all, but it may make sense to continue on EPIPE since the
behavior is to reset to the first available message?

Lucas De Marchi

>-Chris


More information about the igt-dev mailing list