[igt-dev] [PATCH i-g-t] kms_flip: Skip interruptible testing for negative and hangs tests

Chris Wilson chris at chris-wilson.co.uk
Sat Apr 4 10:41:40 UTC 2020


Negative tests are API tests that will be rejected before we either
waiting. Repeating them expecting it to be interrupted is a forlorn
hope.

Hang tests are expected to be blocked until they can be resolved by
hangcheck. Repeating those to see how a long wait responds when
interrupted is counter purpose, just a waste of time.

Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
---
 tests/kms_flip.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/tests/kms_flip.c b/tests/kms_flip.c
index 9ce83c53d..c95838c73 100755
--- a/tests/kms_flip.c
+++ b/tests/kms_flip.c
@@ -1600,10 +1600,17 @@ igt_main
 			continue;
 
 		/*
+		 * -EINVAL are negative API tests, they are rejected before
+		 *  any waits and so not subject to interruptiblity.
+		 *
 		 * -EBUSY needs to complete in a single vblank, skip them for
 		 * interruptible tests
+		 *
+		 * HANGs are slow enough and interruptible hang testing is
+		 * an oxymoron (can't force the wait-for-hang if being
+		 * interrupted all the time).
 		 */
-		if (tests[i].flags & TEST_EBUSY)
+		if (tests[i].flags & (TEST_EINVAL | TEST_EBUSY | TEST_HANG))
 			continue;
 
 		igt_subtest_f( "%s-interruptible", tests[i].name)
-- 
2.26.0



More information about the igt-dev mailing list