[igt-dev] [PATCH i-g-t] i915/perf_pmu: Add the missing igt_dynamic to dynamic rcs* test selection

Chris Wilson chris at chris-wilson.co.uk
Mon Apr 6 08:53:09 UTC 2020


An important ingredient to using igt_subtest_with_dynamic is to include
an igt_dynamic at some point.

Reported-by: Petri Latvala <petri.latvala at intel.com>
Fixes: 311cb1b360b7 ("i915/perf_pmu: Dynamic active engine tests")
Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
Cc: Petri Latvala <petri.latvala at intel.com>
---
 tests/perf_pmu.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/perf_pmu.c b/tests/perf_pmu.c
index 92aee1d1d..b9ca6a493 100644
--- a/tests/perf_pmu.c
+++ b/tests/perf_pmu.c
@@ -1866,7 +1866,8 @@ static void faulting_read(int gem_fd, const struct mmap_offset *t)
 
 #define test_each_rcs(T, i915, e) \
 	igt_subtest_with_dynamic(T) __for_each_physical_engine(i915, e) \
-		for_each_if((e)->class == I915_ENGINE_CLASS_RENDER)
+		for_each_if((e)->class == I915_ENGINE_CLASS_RENDER) \
+			igt_dynamic_f("%s", e->name)
 
 igt_main
 {
-- 
2.26.0



More information about the igt-dev mailing list