[igt-dev] [PATCH i-g-t 2/8] lib/params: start renaming functions igt_params_*

Jani Nikula jani.nikula at intel.com
Tue Apr 21 08:07:29 UTC 2020


On Tue, 21 Apr 2020, Juha-Pekka Heikkila <juhapekka.heikkila at gmail.com> wrote:
> On 20.4.2020 12.33, Petri Latvala wrote:
>> On Sun, Apr 19, 2020 at 06:17:44PM +0300, Juha-Pekka Heikkila wrote:
>>> From: Jani Nikula <jani.nikula at intel.com>
>>>
>>> based on patch from Jani Nikula.
>> 
>> 
>>  From Jani, and then based on Jani.
>> 
>> Please keep the original S-o-b as well as your own.
>> 
>> 
>
> Yea, that look like a mess now. I'm thinking I should take authorship on 
> changed patches. I don't think I can keep Jani's S-o-b for changed 
> patches. I'll anyway need to make changes yet so this it's not final 
> revision, currently I have i915 hardcoded there for parameter path.

Like I've said way back when, it's fine with me for you to take
authorship when you change the patches. The starting point was a hacky
pile of patches that I threw over the fence, and I think it would be
silly for me to insist on retaining the authorship.

That said, Signed-off-by is a legal thing, and you *should* retain
that. See https://developercertificate.org/ for what it signifies.

BR,
Jani.

-- 
Jani Nikula, Intel Open Source Graphics Center


More information about the igt-dev mailing list