[igt-dev] [PATCH i-g-t]tests/i915/gem_ringfill:Adjusted test to utilize all available engines.

Chris Wilson chris at chris-wilson.co.uk
Thu Apr 30 11:31:44 UTC 2020


Quoting sai gowtham (2020-04-30 12:23:42)
>         for (m = modes; m->suffix; m++) {
> -               const struct intel_execution_engine *e;
> -
> +               /* Legacy testing must be first. */
>                 for (e = intel_execution_engines; e->name; e++) {
> -                       igt_subtest_f("%s%s%s",
> -                                     m->basic && !e->exec_id ? "basic-" : "",
> -                                     e->name,
> -                                     m->suffix) {
> -                               igt_skip_on(m->flags & NEWFD && master);
> -                               run_test(fd, eb_ring(e), m->flags, m->timeout);
> +                       struct intel_execution_engine2 e2__;
> +                       e2__ = gem_eb_flags_to_engine(eb_ring(e));
> +                       if (e2__.flags == -1)
> +                               continue;
> +                       e2 = &e2__;
> +                       igt_skip_on(m->flags & NEWFD && master);
> +                       igt_subtest_f("legacy-%s%s%s",
> +                                       m->basic && !e->exec_id ? "basic-" : "",
> +                                       e->name,
> +                                       m->suffix)
> +                               run_test(fd, e2, m->flags, m->timeout);
> +               }
> +               igt_skip_on(m->flags & NEWFD && master);
> +               igt_subtest_with_dynamic_f("%s%s", m->basic  ? "basic" : "",  m->suffix) {
> +                       __for_each_physical_engine(fd, e2) {
> +                               igt_dynamic_f("%s", e2->name) {
> +                                       run_test(fd, e2, m->flags, m->timeout);
> +                               }

Dynamic selection for one and not the other?

Just because of default-forked? Try tuning all for use in BAT.
-Chris


More information about the igt-dev mailing list