[igt-dev] [PATCH i-g-t v31 30/32] lib/intel_batchbuffer: fix intel_bb cache

Chris Wilson chris at chris-wilson.co.uk
Wed Aug 26 16:44:46 UTC 2020


Quoting Zbigniew Kempczyński (2020-08-20 07:30:28)
>  /**
>   * intel_bb_add_object:
>   * @ibb: pointer to intel_bb
> @@ -1543,27 +1594,14 @@ intel_bb_add_object(struct intel_bb *ibb, uint32_t handle,
>                     uint64_t offset, bool write)
>  {
>         struct drm_i915_gem_exec_object2 *object;
> -       struct drm_i915_gem_exec_object2 **found;
> -       uint32_t i;
>  
> -       __reallocate_objects(ibb);
> -
> -       i = ibb->num_objects;
> -       object = &ibb->objects[i];

This. This is the invalid pointer across a reloc of objects.

Ok, gotcha.

Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris


More information about the igt-dev mailing list