[igt-dev] [PATCH i-g-t v32 35/39] lib/intel_batchbuffer: address review comments (canonical types cleanup)

Zbigniew Kempczyński zbigniew.kempczynski at intel.com
Fri Aug 28 13:13:50 UTC 2020


Change to int/int64_t instead __s8/__s64 to avoid mixing type names.

Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>
Cc: Dominik Grzegorzek <dominik.grzegorzek at intel.com>
Cc: Chris Wilson <chris at chris-wilson.co.uk>
---
 lib/intel_batchbuffer.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/intel_batchbuffer.c b/lib/intel_batchbuffer.c
index e3a31beb..be764646 100644
--- a/lib/intel_batchbuffer.c
+++ b/lib/intel_batchbuffer.c
@@ -1215,9 +1215,9 @@ static void __reallocate_objects(struct intel_bb *ibb)
 #define GEN8_HIGH_ADDRESS_BIT 47
 static uint64_t gen8_canonical_addr(uint64_t address)
 {
-	__u8 shift = 63 - GEN8_HIGH_ADDRESS_BIT;
+	int shift = 63 - GEN8_HIGH_ADDRESS_BIT;
 
-	return (__s64)(address << shift) >> shift;
+	return (int64_t)(address << shift) >> shift;
 }
 
 static inline uint64_t __intel_bb_propose_offset(struct intel_bb *ibb)
-- 
2.26.0



More information about the igt-dev mailing list