[igt-dev] [PATCH] tests/kms_color_chamelium fix update success

Karthik B S karthik.b.s at intel.com
Thu Dec 17 10:05:00 UTC 2020


On 12/17/2020 3:08 PM, Kunal Joshi wrote:
> Made a silly mistake and didn't update bool success to true
> fixing that with this patch.
>
> Signed-off-by: Kunal Joshi <kunal1.joshi at intel.com>

LGTM.

Reviewed-by: Karthik B S <karthik.b.s at intel.com>

> ---
>   tests/kms_color_chamelium.c | 12 +++++++++---
>   1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/tests/kms_color_chamelium.c b/tests/kms_color_chamelium.c
> index 43bbe1f2..af2bf994 100644
> --- a/tests/kms_color_chamelium.c
> +++ b/tests/kms_color_chamelium.c
> @@ -611,8 +611,10 @@ run_tests_for_pipe(data_t *data, enum pipe p)
>   				expected_colors[2].b =
>   				0.25 + delta * (i - 2);
>   			if(test_pipe_ctm(data, primary, red_green_blue,
> -					 expected_colors, ctm))
> +					 expected_colors, ctm)) {
> +				success = true;
>   				break;
> +			}
>   		}
>   		igt_assert(success);
>   	}
> @@ -633,8 +635,10 @@ run_tests_for_pipe(data_t *data, enum pipe p)
>   				expected_colors[2].b =
>   				0.5 + delta * (i - 2);
>   			if(test_pipe_ctm(data, primary, red_green_blue,
> -					 expected_colors, ctm))
> +					 expected_colors, ctm)) {
> +				success = true;
>   				break;
> +			}
>   		}
>   		igt_assert(success);
>   	}
> @@ -655,8 +659,10 @@ run_tests_for_pipe(data_t *data, enum pipe p)
>   				expected_colors[2].b =
>   				0.75 + delta * (i - 3);
>   			if(test_pipe_ctm(data, primary, red_green_blue,
> -					 expected_colors, ctm))
> +					 expected_colors, ctm)) {
> +				success = true;
>   				break;
> +			}
>   		}
>   		igt_assert(success);
>   	}




More information about the igt-dev mailing list