[igt-dev] [PATCH i-g-t] i915/i915_query: Add subtests description

apoorva1.singh at intel.com apoorva1.singh at intel.com
Sun Dec 20 17:10:49 UTC 2020


From: Apoorva Singh <apoorva1.singh at intel.com>

Add description for all subtests

Signed-off-by: Apoorva Singh <apoorva1.singh at intel.com>
Cc: Melkaveri, Arjun <arjun.melkaveri at intel.com>
---
 tests/i915/i915_query.c | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/tests/i915/i915_query.c b/tests/i915/i915_query.c
index 29b938e9..7cd190f3 100644
--- a/tests/i915/i915_query.c
+++ b/tests/i915/i915_query.c
@@ -735,34 +735,47 @@ igt_main
 		devid = intel_get_drm_devid(fd);
 	}
 
+	igt_describe("Verify that query ioctl doesn't succeed with invalid query struct");
 	igt_subtest("query-garbage")
 		test_query_garbage(fd);
 
+	igt_describe("Check the query ioctl behaviour with invalid/partial-invalid "
+	       "query item struct");
 	igt_subtest("query-garbage-items") {
 		igt_require(query_topology_supported(fd));
 		test_query_garbage_items(fd);
 	}
 
+	igt_describe("Verify that kernel writes the data at correct place while "
+	       "filing topology info");
 	igt_subtest("query-topology-kernel-writes") {
 		igt_require(query_topology_supported(fd));
 		test_query_topology_kernel_writes(fd);
 	}
 
+	igt_describe("Test that query ioctl querying topology info fails for device "
+	       "which doesn't support topology query");
 	igt_subtest("query-topology-unsupported") {
 		igt_require(!query_topology_supported(fd));
 		test_query_topology_unsupported(fd);
 	}
 
+	igt_describe("Verfiy that slice/subslice masks retrieved using legacy getparam "
+	       "and new query ioctl are same");
 	igt_subtest("query-topology-coherent-slice-mask") {
 		igt_require(query_topology_supported(fd));
 		test_query_topology_coherent_slice_mask(fd);
 	}
 
+	igt_describe("Verify that total number of EUs obtained using getparam "
+	       "and topology query ioctl are same");
 	igt_subtest("query-topology-matches-eu-total") {
 		igt_require(query_topology_supported(fd));
 		test_query_topology_matches_eu_total(fd);
 	}
 
+	igt_describe("Verfiy that some known specifications based on PCI id matches "
+	       "with the corresponding values obtained using topology query ioctl");
 	igt_subtest("query-topology-known-pci-ids") {
 		igt_require(query_topology_supported(fd));
 		igt_require(IS_HASWELL(devid) || IS_BROADWELL(devid) ||
@@ -771,14 +784,18 @@ igt_main
 		test_query_topology_known_pci_ids(fd, devid);
 	}
 
+	igt_describe("Test querying engine info");
 	igt_subtest_group {
 		igt_fixture {
 			igt_require(query_engine_info_supported(fd));
 		}
 
+		igt_describe("Verify the query ioctl behaviour with invalid values");
 		igt_subtest("engine-info-invalid")
 			engines_invalid(fd);
 
+		igt_describe("Basic sanity test of query ioctl and the engine info "
+		       "obtained using it");
 		igt_subtest("engine-info")
 			engines(fd);
 	}
-- 
2.25.1



More information about the igt-dev mailing list