[igt-dev] [PATCH i-g-t] i915/gem_reset_stats: Call noop() with relevant params

[Chris Wilson]

Quoting apoorva1.singh at intel.com (2020-12-28 09:52:07)
> @@ -350,8 +350,8 @@ static void test_ban(const struct intel_execution_engine *e)
>         inject_hang(fd_bad, 0, e, BAN | ASYNC);
>         active_count++;
>  
> -       noop(fd_good, 0, e);
> -       noop(fd_good, 0, e);
> +       igt_assert(noop(fd_bad, 0, e) > 0);
> +       igt_assert(noop(fd_good, 0, e) > 0);

Why?
>  
>         while (retry--) {
>                 inject_hang(fd_bad, 0, e, BAN);

> @@ -409,8 +409,8 @@ static void test_ban_ctx(const struct intel_execution_engine *e)
>         inject_hang(fd, ctx_bad, e, BAN | ASYNC);
>         active_count++;
>  
> -       noop(fd, ctx_good, e);
> -       noop(fd, ctx_good, e);
> +       igt_assert(noop(fd, ctx_bad, e) > 0);
> +       igt_assert(noop(fd, ctx_good, e) > 0);

Why?

The change looks irrelevant. The bad fd/ctx have hangs inflight, pinging
the good fd/ctx is verification for the later assertions.
-Chris