[igt-dev] [PATCH i-g-t] i915/gem_reset_stats: Check noop submission before bans

Chris Wilson chris at chris-wilson.co.uk
Tue Dec 29 10:49:30 UTC 2020


From: Apoorva Singh <apoorva1.singh at intel.com>

Signed-off-by: Apoorva Singh <apoorva1.singh at intel.com>
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
---
 tests/i915/gem_reset_stats.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/tests/i915/gem_reset_stats.c b/tests/i915/gem_reset_stats.c
index d55b85869..afe2cd99b 100644
--- a/tests/i915/gem_reset_stats.c
+++ b/tests/i915/gem_reset_stats.c
@@ -337,8 +337,8 @@ static void test_ban(const struct intel_execution_engine *e)
 	assert_reset_status(fd_bad, fd_bad, 0, RS_NO_ERROR);
 	assert_reset_status(fd_good, fd_good, 0, RS_NO_ERROR);
 
-	noop(fd_bad, 0, e);
-	noop(fd_good, 0, e);
+	igt_assert_lt(0, noop(fd_bad, 0, e));
+	igt_assert_lt(0, noop(fd_good, 0, e));
 
 	assert_reset_status(fd_bad, fd_bad, 0, RS_NO_ERROR);
 	assert_reset_status(fd_good, fd_good, 0, RS_NO_ERROR);
@@ -346,8 +346,8 @@ static void test_ban(const struct intel_execution_engine *e)
 	inject_hang(fd_bad, 0, e, BAN | ASYNC);
 	active_count++;
 
-	noop(fd_good, 0, e);
-	noop(fd_good, 0, e);
+	igt_assert_lt(0, noop(fd_good, 0, e));
+	igt_assert_lt(0, noop(fd_good, 0, e));
 
 	while (retry--) {
 		inject_hang(fd_bad, 0, e, BAN);
@@ -396,8 +396,8 @@ static void test_ban_ctx(const struct intel_execution_engine *e)
 	assert_reset_status(fd, fd, ctx_good, RS_NO_ERROR);
 	assert_reset_status(fd, fd, ctx_bad, RS_NO_ERROR);
 
-	noop(fd, ctx_bad, e);
-	noop(fd, ctx_good, e);
+	igt_assert_lt(0, noop(fd, ctx_bad, e));
+	igt_assert_lt(0, noop(fd, ctx_good, e));
 
 	assert_reset_status(fd, fd, ctx_good, RS_NO_ERROR);
 	assert_reset_status(fd, fd, ctx_bad, RS_NO_ERROR);
@@ -405,8 +405,8 @@ static void test_ban_ctx(const struct intel_execution_engine *e)
 	inject_hang(fd, ctx_bad, e, BAN | ASYNC);
 	active_count++;
 
-	noop(fd, ctx_good, e);
-	noop(fd, ctx_good, e);
+	igt_assert_lt(0, noop(fd, ctx_good, e));
+	igt_assert_lt(0, noop(fd, ctx_good, e));
 
 	while (retry--) {
 		inject_hang(fd, ctx_bad, e, BAN);
-- 
2.30.0.rc2



More information about the igt-dev mailing list