[igt-dev] [PATCH i-g-t] tests/i915/gem_set_tiling_vs_pwrite: disable test on gens without ggtt

Chris Wilson chris at chris-wilson.co.uk
Tue Feb 4 08:41:37 UTC 2020


Quoting Zbigniew Kempczyński (2020-02-04 07:21:22)
> Test requires fences to map via ggtt so we can skip it on newer gens.
> 
> Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> ---
>  tests/i915/gem_set_tiling_vs_pwrite.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/i915/gem_set_tiling_vs_pwrite.c b/tests/i915/gem_set_tiling_vs_pwrite.c
> index 25a28191..b37a2ee4 100644
> --- a/tests/i915/gem_set_tiling_vs_pwrite.c
> +++ b/tests/i915/gem_set_tiling_vs_pwrite.c
> @@ -55,6 +55,7 @@ igt_simple_main
>         uint32_t handle;
>  
>         fd = drm_open_driver(DRIVER_INTEL);
> +       gem_require_mappable_ggtt(fd);

It doesn't require the gtt per se. It's use of the gtt is highly
questionable and doesn't quite do what it once did anyway.
-Chris


More information about the igt-dev mailing list