[igt-dev] [PATCH i-g-t] intel-ci: Delegate exhaustive fault-injection to the idle runs

Chris Wilson chris at chris-wilson.co.uk
Tue Feb 4 11:48:37 UTC 2020


i915_module_reload/fault-injection is valuable for its exhaustive trawl
through (hopefully) every path that hits i915_probe_error, unfortunately
such thoroughness comes at a cost. On kbl-guc, it takes almost 3minutes,
and on tgl-y takes over 4 minutes, which is unacceptable for BAT, so leave
it to the shards and idle runs to catch unusual errors on module load.

v2: remove blacklisting to allow module-reload in shards.

Tomi prefers not to have to manually create a runlist for the idle-runs,
so let's take a risk by allowing the module-reload within the shards.

Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
Cc: Martin Peres <martin.peres at linux.intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
Cc: Petri Latvala <petri.latvala at intel.com>
Cc: Tomi Sarvela <tomi.p.sarvela at intel.com>
---
 tests/intel-ci/blacklist.txt          | 2 +-
 tests/intel-ci/fast-feedback.testlist | 2 --
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/tests/intel-ci/blacklist.txt b/tests/intel-ci/blacklist.txt
index 723f24457..181c8cd5f 100644
--- a/tests/intel-ci/blacklist.txt
+++ b/tests/intel-ci/blacklist.txt
@@ -12,7 +12,7 @@ igt at drm_mm(@.*)?
 # self-contained tests, leading to random
 # failures in tests run afterwards.
 ###############################################
-igt at i915_module_load(@.*)?
+#igt at i915_module_load(@.*)? # danger, danger; hope for taints!
 igt at i915_pm_rpm@module-reload
 igt at i915_pm_rpm@gem-execbuf-stress-extra-wait
 ###############################################
diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist
index 40d273c1d..467e11267 100644
--- a/tests/intel-ci/fast-feedback.testlist
+++ b/tests/intel-ci/fast-feedback.testlist
@@ -172,6 +172,4 @@ igt at vgem_basic@sysfs
 
 igt at vgem_basic@unload
 igt at i915_module_load@reload
-igt at i915_module_load@reload-no-display
-igt at i915_module_load@reload-with-fault-injection
 igt at i915_pm_rpm@module-reload
-- 
2.25.0



More information about the igt-dev mailing list