[igt-dev] [PATCH i-g-t v2] intel-ci: Drop b/c pipes from kms_busy fast feedback

Chris Wilson chris at chris-wilson.co.uk
Tue Feb 11 17:03:23 UTC 2020


The principle test for kms_busy is checking the synchronisation between
on-going rendering to a framebuffer and its flip, that is independent of
the pipe. As such for our fast feedback on driver health, we can look at
the first pipe and assume any errors on the rest will be picked up later
in the shards/idle runs.

Each pass of kms_busy is about 25s.

v2: Use the first pipe connected; combine flip/modeset testing into a
single dynamic group.

Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
Cc: Ville Syrjälä <ville.syrjala at linux.intel.com>
---
 tests/intel-ci/fast-feedback.testlist |  4 +---
 tests/kms_busy.c                      | 15 +++++++++++++++
 2 files changed, 16 insertions(+), 3 deletions(-)

diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist
index 467e11267..739e2d46b 100644
--- a/tests/intel-ci/fast-feedback.testlist
+++ b/tests/intel-ci/fast-feedback.testlist
@@ -88,9 +88,7 @@ igt at kms_addfb_basic@unused-handle
 igt at kms_addfb_basic@unused-modifier
 igt at kms_addfb_basic@unused-offsets
 igt at kms_addfb_basic@unused-pitches
-igt at kms_busy@basic-flip-pipe-a
-igt at kms_busy@basic-flip-pipe-b
-igt at kms_busy@basic-flip-pipe-c
+igt at kms_busy@basic
 igt at kms_chamelium@dp-hpd-fast
 igt at kms_chamelium@dp-edid-read
 igt at kms_chamelium@dp-crc-fast
diff --git a/tests/kms_busy.c b/tests/kms_busy.c
index 0172fcb61..7e495fe2c 100644
--- a/tests/kms_busy.c
+++ b/tests/kms_busy.c
@@ -302,6 +302,21 @@ igt_main
 
 	/* XXX Extend to cover atomic rendering tests to all planes + legacy */
 
+	igt_subtest_with_dynamic("basic") { /* just run on the first pipe */
+		enum pipe pipe;
+		igt_output_t *output;
+
+		igt_require(gem_has_ring(display.drm_fd, eb_ring(e)));
+
+		for_each_pipe_with_valid_output(&display, pipe, output) {
+			igt_dynamic("flip")
+				test_flip(&display, eb_ring(e), pipe, false);
+			igt_dynamic("modeset")
+				test_flip(&display, eb_ring(e), pipe, true);
+			break;
+		}
+	}
+
 	for_each_pipe_static(n) igt_subtest_group {
 		igt_hang_t hang;
 
-- 
2.25.0



More information about the igt-dev mailing list