[igt-dev] [PATCH v2 6/8] tests/kms_frontbuffer_tracking: Skip GTT subtests on platforms w/o aperture
Dixit, Ashutosh
ashutosh.dixit at intel.com
Wed Feb 12 05:45:20 UTC 2020
On Mon, 10 Feb 2020 18:31:06 -0800, Imre Deak wrote:
> @@ -3025,6 +3042,9 @@ static void basic_subtest(const struct test_mode *t)
> fb1 = params->primary.fb;
>
> for (r = 0, method = 0; method < IGT_DRAW_METHOD_COUNT; method++, r++) {
> + igt_skip_on(method == IGT_DRAW_MMAP_GTT &&
> + !gem_has_mappable_ggtt(drm.fd));
> +
I don't think this is incorrect. It will result in the entire subtest being
skipped, for all methods, rather than only the GTT method. Need to use
'continue' here.
More information about the igt-dev
mailing list