[igt-dev] [PATCH] [PATCH i-g-t]test/i915/gem_pipe_control_store_loop: Removal of test

Kumar, Ranjeet1 ranjeet1.kumar at intel.com
Fri Feb 21 09:26:57 UTC 2020


Hi Chris,

For the coverage purpose we are enhancing "gem_exec_bad_domains"  to exercise this race condition i.e.  OUT_RELLOC.
I will be sending enhanced "gem_exec_bad_domains"  program by Monday. 

Thanks,
Ranjeet

-----Original Message-----
From: Chris Wilson <chris at chris-wilson.co.uk> 
Sent: Thursday, February 20, 2020 2:34 PM
To: Kumar, Ranjeet1 <ranjeet1.kumar at intel.com>; igt-dev at lists.freedesktop.org
Subject: RE: [igt-dev] [PATCH] [PATCH i-g-t]test/i915/gem_pipe_control_store_loop: Removal of test

Quoting Kumar, Ranjeet1 (2020-02-20 08:50:42)
> Hi Chris ,
> 
> This OUT_RELLOC instruction are covered in gem_exec_bad_domains, gem_write_read_ring_switch test too. 
>  I tried replacing OUT_RELLOC with OUT_RELLOC_FENCED and successfully tests got passed. 

The test is a regression test developed because we found a bug in the kernel that was not being exercised (a race condition during retire). We need to be certain that we retain such coverage. E.g. if we were to reintroduce such a bug, would CI pick it up? [Always a useful exercise to determine the efficacy of CI.] -Chris


More information about the igt-dev mailing list