[igt-dev] [Intel-gfx] [RFC PATCH i-g-t v2 2/2] tests/gem_userptr_blits: Exercise mmap-offset mapping to userptr

Chris Wilson chris at chris-wilson.co.uk
Fri Feb 21 15:38:32 UTC 2020


Quoting Janusz Krzysztofik (2020-02-21 15:36:08)
> Hi Chris,
> 
> Thanks for review.
> 
> On Friday, February 21, 2020 3:28:03 PM CET Chris Wilson wrote:
> > Quoting Janusz Krzysztofik (2020-02-21 11:17:01)
> > > +       /* set object pages in order to activate MMU notifier for it */
> > > +       gem_set_domain(fd, handle, t->domain, t->domain);
> > 
> > I would suggest (a variant?) that also attached a igt_spin_t to the userptr,
> > waited for it to start executing, call igt_spin_set_timeout and then do
> > the munmap.
> 
> OK.  Will that be OK if I prepare a follow up patch with that subtest variant 
> added?

Perfectly acceptable.
-Chris


More information about the igt-dev mailing list