[igt-dev] [PATCH i-g-t] tests/kms_rotation_crc: remove redundant work
Ville Syrjälä
ville.syrjala at linux.intel.com
Fri Feb 28 14:42:13 UTC 2020
On Thu, Feb 27, 2020 at 03:27:03PM +0200, Juha-Pekka Heikkila wrote:
> removed fb does not take part into final crc comparisons.
>
> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila at gmail.com>
> ---
> tests/kms_rotation_crc.c | 13 -------------
> 1 file changed, 13 deletions(-)
>
> diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c
> index 58bebf3..164eade 100644
> --- a/tests/kms_rotation_crc.c
> +++ b/tests/kms_rotation_crc.c
> @@ -54,7 +54,6 @@ typedef struct {
> igt_display_t display;
> struct igt_fb fb;
> struct igt_fb fb_reference;
> - struct igt_fb fb_unrotated;
> struct igt_fb fb_flip;
> igt_crc_t ref_crc;
> igt_crc_t flip_crc;
> @@ -156,7 +155,6 @@ static void remove_fbs(data_t *data)
> {
> igt_remove_fb(data->gfx_fd, &data->fb);
> igt_remove_fb(data->gfx_fd, &data->fb_reference);
> - igt_remove_fb(data->gfx_fd, &data->fb_unrotated);
> igt_remove_fb(data->gfx_fd, &data->fb_flip);
> }
>
> @@ -306,17 +304,6 @@ static void prepare_fbs(data_t *data, igt_output_t *output,
> igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &data->ref_crc);
>
> /*
> - * Prepare the non-rotated reference fb.
> - */
> - igt_create_fb(data->gfx_fd, ref_w, ref_h, pixel_format, tiling, &data->fb_unrotated);
> - paint_squares(data, IGT_ROTATION_0, &data->fb_unrotated, 1.0);
> - igt_plane_set_fb(plane, &data->fb_unrotated);
> - igt_plane_set_rotation(plane, IGT_ROTATION_0);
> - if (plane->type != DRM_PLANE_TYPE_CURSOR)
> - igt_plane_set_position(plane, data->pos_x, data->pos_y);
> - igt_display_commit2(display, COMMIT_ATOMIC);
> -
> - /*
Looks unused indeed.
Reviewed-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> * Prepare the plane with an non-rotated fb let the hw rotate it.
> */
> igt_create_fb(data->gfx_fd, w, h, pixel_format, tiling, &data->fb);
> --
> 2.7.4
>
> _______________________________________________
> igt-dev mailing list
> igt-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
--
Ville Syrjälä
Intel
More information about the igt-dev
mailing list