[igt-dev] [Intel-gfx] [PATCH i-g-t 4/5] i915: Exercise sysfs heartbeat controls

[Chris Wilson]

Quoting Andi Shyti (2020-02-28 23:34:48)
> On Fri, Feb 28, 2020 at 10:43:39AM +0000, Chris Wilson wrote:
> > We [will] expose various per-engine scheduling controls. One of which,
> > 'heartbeat_duration_ms', defines how often we send a heartbeat down the
> > engine to check upon the health of the engine. If a heartbeat does not
> > complete within the interval (or two), the engine is declared hung.
> > 
> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> 
> Someone with not a good eye might swear to have read this patch
> once, and at patch 5/5 he will ask again the same question.
> 
> Why don't we put together in a library the things that patch
> 3/4/5 have in common?

They are. It's basically a repeating pattern of testing with local
assumptions. For the sole reason that I'm not very inventive.
-Chris