[igt-dev] [PATCH i-g-t v4] tests/i915/gem_huc_copy: Enable a HuC copy test

[Ye, Tony]

On 1/10/2020 10:28 AM, Chris Wilson wrote:
> Quoting Robert M. Fosha (2020-01-10 17:41:46)
>> +static bool
>> +check_huc_enabled(int fd)
>> +{
>> +       int dir;
>> +       dir = igt_sysfs_open_parameters(fd);
>> +
>> +       if (dir < 0)
>> +               return 0;
>> +
>> +       if (igt_sysfs_get_u32(dir, "enable_guc") & 2)
>> +               return 1;
>> +       else
>> +               return 0;
> 
> No. If you have this in your userspace, please immediately remove it,
> and backport that to any and all stable branches and releases.
> -Chris

The code is to skip the test when HuC is disabled by the enable_guc 
module parameter. If HuC is disabled by the enable_guc param, then skip 
the test. If the HuC failed to load due to a real error, then fail the 
test.

Could you suggest how to handle HUC_STATUS failure properly without this 
code?

Regards,
Tony

> _______________________________________________
> igt-dev mailing list
> igt-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
>