[igt-dev] [PATCH i-g-t 7/7] tools/intel_panel_fitter: Fix abs(unsigned)

Chris Wilson chris at chris-wilson.co.uk
Tue Jan 14 14:29:29 UTC 2020


Quoting Ville Syrjala (2020-01-14 14:25:23)
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> ../tools/intel_panel_fitter.c: In function ‘change_screen_size’:
> ../tools/intel_panel_fitter.c:183:10: warning: taking the absolute value of unsigned type ‘uint32_t’ {aka ‘unsigned int’} has no effect [-Wabsolute-value]
>   183 |  pos_x = abs((info.tot_width - dst_width)) / 2;
>       |          ^~~
> ../tools/intel_panel_fitter.c:184:10: warning: taking the absolute value of unsigned type ‘uint32_t’ {aka ‘unsigned int’} has no effect [-Wabsolute-value]
>   184 |  pos_y = abs((info.tot_height - dst_height)) / 2;
>       |          ^~~
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>

A bit of a double take on #6 (that was more than I expected would be
required for the warning), series is

Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris


More information about the igt-dev mailing list