[igt-dev] [PATCH i-g-t v2 2/2] runner/json_tests: Test handling of unprintable output from tests

Arkadiusz Hiler arkadiusz.hiler at intel.com
Wed Jan 15 10:44:24 UTC 2020


On Fri, Jan 10, 2020 at 02:06:42PM +0200, Petri Latvala wrote:
> A simple test output with numbers from 1 to 255, both in plain text
> form and as a single byte with that particular value.
> 
> Note that the json spec doesn't require \u-encoding for characters
> other than '"', '\' and the range U+0000 to U+001F, the raw
> non-\u-encoded UTF-8 in the reference.json file for bytes 128 and up
> is what libjson-c outputs for those codepoints and is valid.
> 
> The validity of the json file can be verified with iconv, i.e.
> 
>  $ iconv -f UTF-8 reference.json -o /dev/null && echo it is utf-8
> 
> v2: Rebase over dynamic subtest tests, trivial
> 
> Signed-off-by: Petri Latvala <petri.latvala at intel.com>
> Cc: Arkadiusz Hiler <arkadiusz.hiler at intel.com>
> Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler at intel.com> #v1

still looks good, and patchwork still does not like it... someday I'll
get to fixing the diff parsing logic and probably break other edge cases
in the process :-P

since gitlab's pipeline is passing feel free to merge it

Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler at intel.com>


More information about the igt-dev mailing list