[igt-dev] [PATCH i-g-t 4/4] runner_tests: Test that dynamic subtest failure is handled correctly

Petri Latvala petri.latvala at intel.com
Thu Jan 16 11:47:19 UTC 2020


On Wed, Jan 15, 2020 at 03:09:15PM +0200, Arkadiusz Hiler wrote:
> On Tue, Jan 14, 2020 at 11:17:45AM +0200, Petri Latvala wrote:
> > See also: commit 0e6457f1bfe2 ("lib: Don't dump log buffer when
> > dynamic subtest failure is inherited")
> > 
> > This is quite an explicit top-to-bottom test that we don't get an
> > incorrect warn result for an innocent dynamic subtest. It is tested
> > here in runner_test instead of testing in lib/tests that the extra
> > lines are not printed, because not printing the extra lines is an
> > implementation detail that might change later. The issue is after all
> > about test results parsed by igt_runner.
> > 
> > Signed-off-by: Petri Latvala <petri.latvala at intel.com>
> > Cc: Arkadiusz Hiler <arkadiusz.hiler at intel.com>
> 
> The whole series is
> 
> Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler at intel.com>
> 
> although I would squash patch 3 and 4 together


Squashed and merged, with Arek's IRC ack on the end result.


-- 
Petri Latvala


More information about the igt-dev mailing list