[igt-dev] [PATCH i-g-t v3 3/3] tests/kms_color_chamelium: add subtests to validate color

[Kunal Joshi]

On 2020-01-21 at 15:51:15 +0200, Petri Latvala wrote:
> On Tue, Jan 21, 2020 at 11:24:15AM +0530, Kunal Joshi wrote:
> > To validate color subtests using chamelium, subtests modified
> > to do frame dump comparison instead of crc comparison.
> > Tests require chamelium and will validate color features
> > at pipe level.
> > 
> > (v2)
> >         Comparing framedump with framebuffer reference instead of
> >         comparing two framedump.
> > (v3)
> > 	Moved common functions with kms_color to lib/igt_color
> > 
> > Signed-off-by: Kunal Joshi <kunal1.joshi at intel.com>
> > Signed-off-by: Swati Sharma <swati2.sharma at intel.com>
> > Suggested-by: Uma Shankar <uma.shankar at intel.com>
> > ---
> >  tests/Makefile.am           |   1 +
> >  tests/kms_color_chamelium.c | 759 ++++++++++++++++++++++++++++++++++++++++++++
> 
> 
> Meson changes are missing.
> 
> Looks pretty much what you'd expect from a kms_color ported to use
> chamelium. When you send the next revision, can you also include a
> patch with commit message "HAX: Run in BAT", modifying
> tests/intel-ci/fast-feedback.testlist to add all these new tests
> there. That way we get testing done on chameliums, which we currently
> only have on the BAT machines, not on shards.
> 
> 
> -- 
> Petri Latvala
Thanks petri for the feedback and support.
I will float the next patch with recommended
changes.


Regards
Kunal