[igt-dev] [PATCH i-g-t v4 2/4] Moved common function in kms_color and kms_color_chamelium to kms_color_helper.c

[Petri Latvala]

On Fri, Jan 24, 2020 at 12:07:54PM +0200, Petri Latvala wrote:
> On Thu, Jan 23, 2020 at 01:30:40PM +0530, Kunal Joshi wrote:
> > kms_color and kms_color_chamelium shared common functions.
> > Moved them to tests/kms_color_helper.c to avoid code duplication.
> > 
> > (v4)
> >         Made a library kms_color_helper.c which is specific to
> >         kms_color and kms_color_chamelium.
> > 
> > Signed-off-by: Kunal Joshi <kunal1.joshi at intel.com>
> > Signed-off-by: Swati Sharma <swati2.sharma at intel.com>
> > Suggested-by: Uma Shankar <uma.shankar at intel.com>
> > ---
> >  tests/Makefile.am        |   3 +
> >  tests/Makefile.sources   |  13 +-
> >  tests/kms_color.c        | 383 +---------------------------------------------
> >  tests/kms_color.h        | 105 +++++++++++++
> >  tests/kms_color_helper.c | 386 +++++++++++++++++++++++++++++++++++++++++++++++
> >  tests/meson.build        |  19 ++-
> >  6 files changed, 525 insertions(+), 384 deletions(-)
> >  create mode 100644 tests/kms_color.h
> >  create mode 100644 tests/kms_color_helper.c
> > 
> > diff --git a/tests/Makefile.am b/tests/Makefile.am
> > index fc30524..87ffec2 100644
> > --- a/tests/Makefile.am
> > +++ b/tests/Makefile.am
> > @@ -13,11 +13,14 @@ endif
> >  if HAVE_CHAMELIUM
> >  TESTS_progs += \
> >  	kms_chamelium \
> > +	kms_color_chamelium \

Well, this I missed: The build system changes related to
kms_color_chamelium need to be moved to the patch that adds
kms_color_chamelium.


-- 
Petri Latvala