[igt-dev] [PATCH i-g-t] lib/color_encoding: Fix up support for XYUV format.

[Shankar, Uma]

> -----Original Message-----
> From: igt-dev <igt-dev-bounces at lists.freedesktop.org> On Behalf Of Bob Paauwe
> Sent: Friday, January 10, 2020 12:04 AM
> To: igt-dev at lists.freedesktop.org
> Subject: [igt-dev] [PATCH i-g-t] lib/color_encoding: Fix up support for XYUV format.

We can drop the "." in the commit header.

The patch looks good.
Reviewed-by: Uma Shankar <uma.shankar at intel.com>

> 
> Add XYUV8888 to the list of DRM Formats to test.
> 
> Also fix the byte order for the format.
> 
> Signed-off-by: Bob Paauwe <bob.j.paauwe at intel.com>
> ---
>  lib/igt_color_encoding.c | 1 +
>  lib/igt_fb.c             | 6 +++---
>  2 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/lib/igt_color_encoding.c b/lib/igt_color_encoding.c index
> 7de6d5ab..a7bd2b22 100644
> --- a/lib/igt_color_encoding.c
> +++ b/lib/igt_color_encoding.c
> @@ -160,6 +160,7 @@ static const struct color_encoding_format {
>  	{ DRM_FORMAT_XVYU2101010, 1023.f, 64.f, 940.f, 64.f, 512.f, 960.f },
>  	{ DRM_FORMAT_XVYU12_16161616, 65520.f, 4096.f, 60160.f, 4096.f,
> 32768.f, 61440.f },
>  	{ DRM_FORMAT_XVYU16161616, 65535.f, 4096.f, 60160.f, 4096.f, 32768.f,
> 61440.f },
> +	{ DRM_FORMAT_XYUV8888, 255.f, 16.f, 235.f, 16.f, 128.f, 240.f },
>  };
> 
>  static const struct color_encoding_format *lookup_fourcc(uint32_t fourcc) diff --git
> a/lib/igt_fb.c b/lib/igt_fb.c index c81b9de8..7409e6b3 100644
> --- a/lib/igt_fb.c
> +++ b/lib/igt_fb.c
> @@ -2634,9 +2634,9 @@ static void get_yuv_parameters(struct igt_fb *fb, struct
> yuv_parameters *params)
>  		break;
> 
>  	case DRM_FORMAT_XYUV8888:
> -		params->y_offset = fb->offsets[0] + 1;
> -		params->u_offset = fb->offsets[0] + 2;
> -		params->v_offset = fb->offsets[0] + 3;
> +		params->y_offset = fb->offsets[0] + 2;
> +		params->u_offset = fb->offsets[0] + 1;
> +		params->v_offset = fb->offsets[0] + 0;
>  		break;
>  	}
>  }
> --
> 2.21.0
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev