[igt-dev] [PATCH i-g-t 2/3] tests/kms_fbcon_fbt: User interactive debug helper

Daniel Vetter daniel.vetter at ffwll.ch
Tue Jan 28 11:25:48 UTC 2020


Instead of hand-rolling our own which can only be enabled by recompiling.

Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>
---
 tests/kms_fbcon_fbt.c | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/tests/kms_fbcon_fbt.c b/tests/kms_fbcon_fbt.c
index 506848cfcf47..236e09ea1ebd 100644
--- a/tests/kms_fbcon_fbt.c
+++ b/tests/kms_fbcon_fbt.c
@@ -37,8 +37,6 @@ IGT_TEST_DESCRIPTION("Test the relationship between fbcon and the frontbuffer "
 
 #define MAX_CONNECTORS 32
 
-static bool do_wait_user = false;
-
 struct drm_info {
 	int fd;
 	int debugfs_fd;
@@ -48,12 +46,8 @@ struct drm_info {
 
 static void wait_user(const char *msg)
 {
-	if (!do_wait_user)
-		return;
-
-	igt_info("%s Press enter...\n", msg);
-	while (getchar() != '\n')
-		;
+	igt_info("%s\n", msg);
+	igt_debug_wait_for_keypress("fbt");
 }
 
 static void setup_drm(struct drm_info *drm)
-- 
2.24.1



More information about the igt-dev mailing list