[igt-dev] [PATCH i-g-t] runner: Make the result an incomplete if a test is killed due to taint

Chris Wilson chris at chris-wilson.co.uk
Wed Jan 29 14:01:02 UTC 2020


Quoting Petri Latvala (2020-01-29 13:56:19)
> If we're checking for taints, we kill the test as soon as we notice a
> taint. Out of the box, such killing will get marked as such and yields
> a 'timeout' result, which is misleading. The test didn't spend too
> much time, it just did nasties.
> 
> Make sure taint-killing results in an 'incomplete' result
> instead. It's still not completely truthful for the state of the
> testing but closer than a 'timeout'. And stands out more in CI result
> analysis.
> 
> Suggested-by: Chris Wilson <chris at chris-wilson.co.uk>
> Signed-off-by: Petri Latvala <petri.latvala at intel.com>
> Cc: Chris Wilson <chris at chris-wilson.co.uk>

Incomplete has been synonymous in my mind with the "kernel oopsed" so it
worksforme. Even if the HW dies, everyone blames the kernel for letting
it die!

Having the "test ran slowly for 360s+" timeout be distinct from a death
is important for me when scanning the results, so

Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris


More information about the igt-dev mailing list