[igt-dev] [PATCH i-g-t 1/9] lib/ioctl_wrappers: Query if device supports set/get legacy tiling

[Chris Wilson]

Quoting Imre Deak (2020-01-29 18:15:53)
> From: Vanshidhar Konda <vanshidhar.r.konda at intel.com>
> 
> Add a method to query if the device supports setting and getting legacy
> tiling formats for buffer objects.

Legacy is never a good choice for a name longterm. Say what you mean

gem_mmap_gtt_uses_tiling or
gem_mmap_aperture_has_detiling

> 
> Signed-off-by: Vanshidhar Konda <vanshidhar.r.konda at intel.com>
> Reviewed-by: Ashutosh Dixit <ashutosh.dixit at intel.com>
> Signed-off-by: Imre Deak <imre.deak at intel.com>
> ---
>  lib/ioctl_wrappers.c | 17 +++++++++++++++++
>  lib/ioctl_wrappers.h |  1 +
>  2 files changed, 18 insertions(+)
> 
> diff --git a/lib/ioctl_wrappers.c b/lib/ioctl_wrappers.c
> index 627717d2..c1abb575 100644
> --- a/lib/ioctl_wrappers.c
> +++ b/lib/ioctl_wrappers.c
> @@ -133,6 +133,23 @@ __gem_get_tiling(int fd, struct drm_i915_gem_get_tiling *arg)
>         return err;
>  }
>  
> +/**
> + * gem_has_legacy_hw_tiling:
> + * @fd: open i915 drm file descriptor
> + *
> + * Feature check to query if the device supports setting/getting
> + * legacy tiling formats for buffer objects
> + *
> + * Returns: True if tiling is supported
> + */
> +bool
> +gem_has_legacy_hw_tiling(int fd)
> +{
> +       struct drm_i915_gem_get_tiling arg = {};
> +
> +       return (__gem_get_tiling(fd, &arg) != -EOPNOTSUPP);

There was already an interface for this, the number of available fences.
-Chris