[igt-dev] [PATCH i-g-t v6 1/1] tests/i915/gem_ctx_persistence: Set context with supported engines

Chris Wilson chris at chris-wilson.co.uk
Thu Jan 30 10:55:05 UTC 2020


Quoting Tvrtko Ursulin (2020-01-30 10:52:26)
> 
> On 30/01/2020 10:31, Tvrtko Ursulin wrote:
> > 
> > On 29/01/2020 21:09, Chris Wilson wrote:
> >> Quoting Bommu Krishnaiah (2020-01-29 18:10:02)
> >>> Update the context with supported engines on the platform with set_property
> >>> I915_CONTEXT_PARAM_ENGINES to make sure the work load is submitted to
> >>> the available engines only.
> >>>
> >>> v2: addressed the review comments.
> >>> v3: addressed v2 review comments.
> >>> V4: Re-introduced the gem_context_set_all_engines() API,test_process_mixed()
> >>> test creating new forked process, to set engine map to new forked process
> >>> I added gem_context_set_all_engines() API.
> >>> v5: addressed v4 review comments.
> >>> v6: addressed chris comments.
> >>
> >> This is totally useless as a recording of the history. Explain why you
> >> had to make the changes, for posterity.
> >>
> >>> -       __for_each_static_engine(e) {
> >>> +       for_each_engine(e, i915) {
> >>
> >> Incorrect change that leads to compiler warnings and prevents the legacy
> >> tests being listed by CI.
> >>
> >> I've given up and fixed it.
> 
> Where's your version Chris?

21f4d0f72c0a3519270712565b2fe688157fc18b
-Chris


More information about the igt-dev mailing list