[igt-dev] [PATCH i-g-t 2/9] lib/igt_fb: Fix creating FBs on platforms w/o HW detiling

[Imre Deak]

On Thu, Jan 30, 2020 at 10:11:46AM +0000, Chris Wilson wrote:
> Quoting Imre Deak (2020-01-29 18:15:54)
> > On platforms w/o HW detiling don't fail creating the FB due to the
> > expected error from the set_tiling IOCTL.
> > 
> > Most of the tests use a cairo surface to draw, which don't depend on the
> > HW detiling. Other tests (using lib/igt_draw.c or drawing to the FB
> > directly, like kms_draw_crc, kms_frontbuffer) are failing atm and will
> > need to be fixed separately.
> > 
> > Cc: Juha-Pekka Heikkila <juhapekka.heikkila at gmail.com>
> > Signed-off-by: Imre Deak <imre.deak at intel.com>
> > ---
> >  lib/igt_fb.c | 7 ++++---
> >  1 file changed, 4 insertions(+), 3 deletions(-)
> > 
> > diff --git a/lib/igt_fb.c b/lib/igt_fb.c
> > index c81b9de8..ec7e9991 100644
> > --- a/lib/igt_fb.c
> > +++ b/lib/igt_fb.c
> > @@ -944,9 +944,10 @@ static int create_bo_for_fb(struct igt_fb *fb)
> >  
> >                 if (is_i915_device(fd)) {
> >                         fb->gem_handle = gem_create(fd, fb->size);
> > -                       gem_set_tiling(fd, fb->gem_handle,
> > -                                      igt_fb_mod_to_tiling(fb->modifier),
> > -                                      fb->strides[0]);
> > +                       if (gem_has_legacy_hw_tiling(fd))
> > +                               gem_set_tiling(fd, fb->gem_handle,
> > +                                              igt_fb_mod_to_tiling(fb->modifier),
> > +                                              fb->strides[0]);
> 
> /* If we can't use fences, we won't use ggtt detiling later */
> __gem_set_tiling()

Ok.

> -Chris