[igt-dev] [PATCH i-g-t] tests/i915/gem_tiled_.*blits: skip the tests on newer gens

[Chris Wilson]

Quoting Zbigniew Kempczyński (2020-01-30 15:17:57)
> Skip the tests on newer gens when no fences are available
> and gem_set_tiling() cannot succeed.
> 
> Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> ---
>  tests/i915/gem_tiled_blits.c       | 1 +
>  tests/i915/gem_tiled_fence_blits.c | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/tests/i915/gem_tiled_blits.c b/tests/i915/gem_tiled_blits.c
> index df0699f3..ba0920da 100644
> --- a/tests/i915/gem_tiled_blits.c
> +++ b/tests/i915/gem_tiled_blits.c
> @@ -204,6 +204,7 @@ igt_main
>                 fd = drm_open_driver(DRIVER_INTEL);
>                 igt_require_gem(fd);
>                 gem_require_blitter(fd);
> +               gem_require_mappable_ggtt(fd);

Well, I can think of a use for this for testing implicit HW tiling
across the aperture thrashing...

>                 bufmgr = drm_intel_bufmgr_gem_init(fd, 4096);
>                 drm_intel_bufmgr_gem_enable_reuse(bufmgr);
> diff --git a/tests/i915/gem_tiled_fence_blits.c b/tests/i915/gem_tiled_fence_blits.c
> index 93c79dc2..62fd1328 100644
> --- a/tests/i915/gem_tiled_fence_blits.c
> +++ b/tests/i915/gem_tiled_fence_blits.c
> @@ -214,6 +214,7 @@ igt_main
>                 fd = drm_open_driver(DRIVER_INTEL);
>                 igt_require_gem(fd);
>                 gem_require_blitter(fd);
> +               gem_require_mappable_ggtt(fd);

but this is targeting the fence above and beyond the gem_tiled_blits.

Sweeten the changelog by describing how you write a selftest to verify
the implicit HW tiling independently of fence registers.
-Chris