[igt-dev] [Intel-gfx] [PATCH i-g-t] tests/i915/gem_ctx_persistence: Convert engine subtests to dynamic

Chris Wilson chris at chris-wilson.co.uk
Thu Jan 30 20:50:38 UTC 2020


Quoting Tvrtko Ursulin (2020-01-30 20:44:57)
> 
> On 30/01/2020 20:41, Tvrtko Ursulin wrote:
> > From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> >   
> > -     igt_subtest("smoketest")
> > -             smoketest(i915);
> 
> I also moved this one to before the default context is configured with 
> engine map, since it uses legacy for_each_physical_engine, and is 
> therefore confused as to engine selection.
> 
> But perhaps better would be to leave it last and convert to 
> __for_each_physical_engine. In the spirit of a smoke test is to exercise 
> all engines after all.

Earlier was fine by me. It did make a bit of sense to get the smoketest
running earlier, but later is also fine.
-Chris


More information about the igt-dev mailing list