[igt-dev] [Intel-gfx] [PATCH i-g-t v2] tests/i915/gem_ctx_persistence: Convert engine subtests to dynamic

Tvrtko Ursulin tvrtko.ursulin at linux.intel.com
Thu Jan 30 20:59:45 UTC 2020


On 30/01/2020 20:56, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2020-01-30 20:52:56)
>> @@ -772,91 +787,64 @@ igt_main
>>                  igt_allow_hang(i915, 0, 0);
>>          }
>>   
>> -       igt_subtest("idempotent")
>> -               test_idempotent(i915);
>> -
>> -       igt_subtest("clone")
>> -               test_clone(i915);
>> -
>> -       igt_subtest("file")
>> -               test_nonpersistent_file(i915);
>> -
>> -       igt_subtest("process")
>> -               test_process(i915);
>> -
>> -       igt_subtest("processes")
>> -               test_processes(i915);
>> -
>> -       igt_subtest("hostile")
>> -               test_nohangcheck_hostile(i915);
>> -       igt_subtest("hang")
>> -               test_nohangcheck_hang(i915);
> 
> Could we keep these outside of the engine subtest groups?
> I'd like to keep them distinct as they aren't written with verifying
> engines per se, but the general context parameter.
> 
> There should be per-engine equivalents to the above already where
> appropriate.

Depends how you look at it, I envisioned two subgroups as telling me 
when the default context is really default and when it has been 
configured with an engine map.

Oh right contexts... okay I need a third subgroup.

Regards,

Tvrtko




More information about the igt-dev mailing list