[igt-dev] [PATCH i-g-t] tests/kms_frontbuffer_tracking: fix fbc checking rules

[Ville Syrjälä]

On Fri, Jan 31, 2020 at 01:41:09PM +0200, Juha-Pekka Heikkila wrote:
> Fix FBC checking rules for scaledprimary subtests
> 
> References: https://gitlab.freedesktop.org/drm/intel/issues/160
> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila at gmail.com>

Reviewed-by: Ville Syrjälä <ville.syrjala at linux.intel.com>

> ---
>  tests/kms_frontbuffer_tracking.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/kms_frontbuffer_tracking.c b/tests/kms_frontbuffer_tracking.c
> index c788b59..2c765c3 100644
> --- a/tests/kms_frontbuffer_tracking.c
> +++ b/tests/kms_frontbuffer_tracking.c
> @@ -2614,16 +2614,16 @@ static void scaledprimary_subtest(const struct test_mode *t)
>  	do_assertions(DONT_ASSERT_CRC);
>  
>  	/*
> -	 * On gen <= 10 HW, FBC is not enabled on a plane with a Y offset
> +	 * On gen >= 9 HW, FBC is not enabled on a plane with a Y offset
>  	 * that isn't divisible by 4, because it causes FIFO underruns.
>  	 *
>  	 * Check that FBC is disabled.
>  	 */
>  	igt_fb_set_position(&new_fb, reg->plane,
> -			    reg->x + reg->w / 4, reg->y + src_y_upscale + 3);
> +			    reg->x + reg->w / 4, (reg->y + src_y_upscale) | 3);
>  	igt_fb_set_size(&new_fb, reg->plane, reg->w / 2, reg->h / 2);
>  	igt_display_commit2(&drm.display, COMMIT_UNIVERSAL);
> -	do_assertions(DONT_ASSERT_CRC | (gen <= 10 ? ASSERT_FBC_DISABLED : 0));
> +	do_assertions(DONT_ASSERT_CRC | (gen >= 9 ? ASSERT_FBC_DISABLED : 0));
>  
>  	/* Back to the good and old blue fb. */
>  	igt_plane_set_fb(reg->plane, old_fb);
> -- 
> 2.7.4
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev

-- 
Ville Syrjälä
Intel