[igt-dev] [PATCH i-g-t] lib: Fix interface descriptor fills

[Zbigniew Kempczyński]

On Fri, Jul 03, 2020 at 02:23:33PM +0300, Mika Kuoppala wrote:
> For gen8+ we need to increment the pointer for interface
> descriptor size amount. Otherwise the next indirect item
> introduced will overwrite our descriptor.
> 
> Apparently this has not caused much havoc as interface
> descs has been the last item.

Eh, missed that :/ Thanks for fix.

Reviewed-by: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>

> 
> Cc: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Signed-off-by: Mika Kuoppala <mika.kuoppala at linux.intel.com>
> ---
>  lib/gpu_cmds.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/lib/gpu_cmds.c b/lib/gpu_cmds.c
> index 417253a7..81156d25 100644
> --- a/lib/gpu_cmds.c
> +++ b/lib/gpu_cmds.c
> @@ -363,6 +363,8 @@ gen8_fill_interface_descriptor(struct intel_bb *ibb,
>  
>  	idd->desc6.num_threads_in_tg = 1;
>  
> +	intel_bb_ptr_add(ibb, sizeof(*idd));
> +
>  	return offset;
>  }
>  
> @@ -399,6 +401,8 @@ gen11_fill_interface_descriptor(struct intel_bb *ibb,
>  
>  	idd->desc6.num_threads_in_tg = 1;
>  
> +	intel_bb_ptr_add(ibb, sizeof(*idd));
> +
>  	return offset;
>  }
>  
> -- 
> 2.17.1
>