[igt-dev] [PATCH i-g-t v16 4/4] intel-ci/fast-feedback: add api_intel_bb tests

Zbigniew Kempczyński zbigniew.kempczynski at intel.com
Fri Jul 3 19:45:20 UTC 2020


On Fri, Jul 03, 2020 at 07:19:02PM +0100, Chris Wilson wrote:
> Quoting Zbigniew Kempczyński (2020-07-03 12:31:02)
> > intel_bb has to replace libdrm intel_batchbuffer. We need to know
> > any changes in its infrastructure doesn't lead to regression.
> > Add api_intel_bb to BAT to be verified on the very beginning.
> > Test execution time is very short so it shouldn't be noticable
> > on CI.
> 
> Ok, up to here, all done. But BAT for an igt selftest? The criteria for
> BAT is "catch the most amount of bugs in the least amount of time", for
> which we like to have tests that exercise a lot of the driver very
> quickly. I don't think this adds anything? [I would be very happy to be
> proved wrong with some path coverage / kcov]. So I don't see much reason
> to have it in BAT, and just leave it to shards/idle.
> -Chris

Ok, I won't complain :) Especially the criteria you've explained 
doesn't match to api_intel_bb. In cases I'll need to update it I will
just use HAX and leave final commit to the shards run.

--
Zbigniew


More information about the igt-dev mailing list