[igt-dev] [PATCH i-g-t] lib/igt_fb: remove extra parameters from igt_put_cairo_ctx

[Melissa Wen]

On 07/07, Arkadiusz Hiler wrote:
> On Mon, Jul 06, 2020 at 12:50:59PM -0300, Melissa Wen wrote:
> > The function igt_put_cairo_ctx currently requires three parameters, but only
> > one of them is used in it. This patch removes the useless parameters, making
> > the code more readable and cohesive. It also applies the change to all
> > occurrences of the function in the code.
> > 
> > Signed-off-by: Melissa Wen <melissa.srw at gmail.com>
> Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler at intel.com>
> 
> Thanks for the patch, it's merged now :-)
> 
> For similar refactors you may find coccinelle[0] handy.
> 
> There's some examples in lib/igt.cocci + a few people use that tool to
> do the changes and posted the cocci patch as a part of the commit message.
> e.g.: 7ff35cc1d0b3 ("lib/igt_buf: Extend igt_buf to include two color surfaces")
> 
> [0]: http://coccinelle.lip6.fr/
> 
Hi Arek,

Thanks for reviewing. I'll try Coccinelle next time.

I sent two other patchsets (one for documentation and another with minor
fixes in the kms_cursor_crc test) that stuck. They succeeded at
CI.BAT and failed at CI.IGT; however, the failures look like a false
positive.

https://patchwork.freedesktop.org/series/78814/
https://patchwork.freedesktop.org/series/78813/

Do you mind taking a look and giving me some feedback?

Thanks in advance,

Melissa
> -- 
> Cheers,
> Arek
> 
> -- 
> You received this message because you are subscribed to the Google Groups "Kernel USP" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to kernel-usp+unsubscribe at googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/kernel-usp/20200707150750.62zmal6s45njyxet%40ahiler-desk1.fi.intel.com.