[igt-dev] [PATCH i-g-t 05/11] tests/kms_lease: Read crtc id for a valid pipe

[Arkadiusz Hiler]

On Sun, Jul 12, 2020 at 01:35:56AM +0530, Mohammed Khajapasha wrote:
> Read crtc id for enabled pipes only.
> 
> Signed-off-by: Mohammed Khajapasha <mohammed.khajapasha at intel.com>
> ---
>  tests/kms_lease.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/kms_lease.c b/tests/kms_lease.c
> index 75a1149c..4045fbca 100644
> --- a/tests/kms_lease.c
> +++ b/tests/kms_lease.c
> @@ -136,9 +136,11 @@ static enum pipe crtc_id_to_pipe(igt_display_t *display, uint32_t crtc_id)
>  {
>  	enum pipe pipe;
>  
> -	for (pipe = 0; pipe < display->n_pipes; pipe++)
> -		if (display->pipes[pipe].crtc_id == crtc_id)
> +	for (pipe = 0; pipe < display->n_pipes; pipe++) {
> +		if (display->pipes[pipe].enabled &&
> +				display->pipes[pipe].crtc_id == crtc_id)

for_each_pipe is already iterating over enabled pipes only, you could
use just that instead of hand-rolling iteration here

-- 
Cheers,
Arek

>  			return pipe;
> +	}
>  	return -1;
>  }
>  
> -- 
> 2.24.1
>