[igt-dev] [PATCH i-g-t, v2] tests/kms_psr2_su: Change to igt_info when the failing of PSR2 enabling

Souza, Jose jose.souza at intel.com
Fri Jul 17 17:26:22 UTC 2020


On Fri, 2020-07-17 at 20:23 +0300, Gwan-gyeong Mun wrote:
> The psr_print_debugfs() function uses igt_debug() for logging.
> As igt_require() does not raise printing out of IGT_LOG_DEBUG level.
> It changes igt_debug() to igt_info() for getting log on
> skipping test case of kms_psr2_su.
> 
> v2: Address José's review comments.
>  - Use igt_info for getting log instead of using igt_assert in order to
>    avoid failure of psr test.
> 

Reviewed-by: José Roberto de Souza <jose.souza at intel.com>

> Cc: José Roberto de Souza <jose.souza at intel.com>
> Signed-off-by: Gwan-gyeong Mun <gwan-gyeong.mun at intel.com>
> ---
>  lib/igt_psr.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/lib/igt_psr.c b/lib/igt_psr.c
> index 899784dc..6cdb97bc 100644
> --- a/lib/igt_psr.c
> +++ b/lib/igt_psr.c
> @@ -45,8 +45,8 @@ static bool psr_active_check(int debugfs_fd, enum psr_mode mode)
>  	ret = igt_debugfs_simple_read(debugfs_fd, "i915_edp_psr_status",
>  				     buf, sizeof(buf));
>  	if (ret < 0) {
> -		igt_debug("Could not read i915_edp_psr_status: %s\n",
> -			  strerror(-ret));
> +		igt_info("Could not read i915_edp_psr_status: %s\n",
> +			 strerror(-ret));
>  		return false;
>  	}
>  
> @@ -244,10 +244,10 @@ void psr_print_debugfs(int debugfs_fd)
>  	ret = igt_debugfs_simple_read(debugfs_fd, "i915_edp_psr_status", buf,
>  				      sizeof(buf));
>  	if (ret < 0) {
> -		igt_debug("Could not read i915_edp_psr_status: %s\n",
> -			  strerror(-ret));
> +		igt_info("Could not read i915_edp_psr_status: %s\n",
> +			 strerror(-ret));
>  		return;
>  	}
>  
> -	igt_debug("%s", buf);
> +	igt_info("%s", buf);
>  }


More information about the igt-dev mailing list