[igt-dev] [PATCH i-g-t 00/11] lib/igt_kms: Add support for display with

Arkadiusz Hiler arkadiusz.hiler at intel.com
Mon Jul 20 09:39:48 UTC 2020


On Fri, Jul 17, 2020 at 03:40:50PM +0000, Mohammed Khajapasha wrote:
> With non-contiguous pipes display, pipe mapping is always not same as
> crtc mapping, For i915 pipe is enum id of i915's crtc object and
> it is not equal to crtc offset of a pipe in mode config list.
> Hence allocating upper bound array for igt_pipe and reading
> pipe id using GET_PIPE_FROM_CRTC_ID ioctl.
> Using crtc offset for a pipe to do ordering pipe with crtc list.
> 
> Example:
> 	With a non-contiguous pipe display, with PIPE_A & PIPE_D
> 	are enabled, PIPE_C & PIPE_B disabled configuration,
> 	the pipe for PIPE_A & D will be '0' and '3' and crtc offsets
> 	are '0' & '1' in mode config list using crtc offset to ordering
> 	enabled pipes with crtc list in mode config.
> 
> v8:
> 	Modified documentation as per review comments by <Hiler, Arkadiusz>

I have posted a few comments on claryifing the documentation a bit further.

There are parts that would be hard to understand by someone not familiar
with the area - making it more friendly will help our fellow
contibutors down the line :-)

with the above fixed:

Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler at intel.com>

-- 
Cheers,
Arek


More information about the igt-dev mailing list