[igt-dev] [i-g-t] tests/kms_big_fb: Use igt_assert on bufmgr

Karthik B S karthik.b.s at intel.com
Tue Jul 21 15:57:37 UTC 2020


Hi,

On 7/15/2020 5:33 PM, Pankaj Bharadiya wrote:
> NULL bufmgr pointer leads to SIGSEGV. Assert on NULL bufmgr so that
> correct failure reason will get dumped in the stack trace.
> 
> Signed-off-by: Pankaj Bharadiya <pankaj.laxminarayan.bharadiya at intel.com>
> ---
>   tests/kms_big_fb.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/tests/kms_big_fb.c b/tests/kms_big_fb.c
> index a754b2997..b19b56f90 100644
> --- a/tests/kms_big_fb.c
> +++ b/tests/kms_big_fb.c
> @@ -649,6 +649,7 @@ igt_main
>   			data.render_copy = igt_get_render_copyfunc(data.devid);
>   
>   		data.bufmgr = drm_intel_bufmgr_gem_init(data.drm_fd, 4096);
> +		igt_assert(data.bufmgr);

Looks good to me.
Reviewed-by: Karthik B S <karthik.b.s at intel.com>
>   		data.batch = intel_batchbuffer_alloc(data.bufmgr, data.devid);
>   	}
>   
> 


More information about the igt-dev mailing list