[igt-dev] [PATCH i-g-t 1/2] runner/resultgen: Remember to close fd to aborted.txt

Chris Wilson chris at chris-wilson.co.uk
Wed Jul 29 12:00:21 UTC 2020


Quoting Petri Latvala (2020-07-29 12:34:24)
> Signed-off-by: Petri Latvala <petri.latvala at intel.com>
> Cc: Arkadiusz Hiler <arkadiusz.hiler at intel.com>
> Cc: Lukasz Fiedorowicz <lukasz.fiedorowicz at intel.com>
> ---
>  runner/resultgen.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/runner/resultgen.c b/runner/resultgen.c
> index e2e162b0..3fe83b43 100644
> --- a/runner/resultgen.c
> +++ b/runner/resultgen.c
> @@ -1637,6 +1637,7 @@ struct json_object *generate_results_json(int dirfd)
>                 add_to_totals("runner", &abortsub, &results);
>  
>                 free_subtests(&abortsub);
> +               close(fd);
>         }
>  
>         free_settings(&settings);

For completeness, I noticed that generate_results_path() has an open
within a matching close.

Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris


More information about the igt-dev mailing list