[igt-dev] [PATCH i-g-t] i915/gem_spin_batch: Remove unncessary non-preemptible workload

Dominik Grzegorzek dominik.grzegorzek at intel.com
Tue Jun 2 08:54:54 UTC 2020


Following the rule "as few non-preemptible spinners as possible", this patch
removes IGT_SPIN_NO_PREEMPTION flag from spin-all subtest, where it was used
as a precaution.

Signed-off-by: Dominik Grzegorzek <dominik.grzegorzek at intel.com>
---
 tests/i915/gem_spin_batch.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/tests/i915/gem_spin_batch.c b/tests/i915/gem_spin_batch.c
index e7dd58ec..af0b67ca 100644
--- a/tests/i915/gem_spin_batch.c
+++ b/tests/i915/gem_spin_batch.c
@@ -147,12 +147,10 @@ static void spin_all(int i915, unsigned int flags)
 		if (flags & PARALLEL_SPIN_NEW_CTX)
 			ctx = gem_context_create(i915);
 
-		/* Prevent preemption so only one is allowed on each engine */
 		spin = igt_spin_new(i915,
 				    .ctx = ctx,
 				    .engine = eb_ring(e),
-				    .flags = (IGT_SPIN_POLL_RUN |
-					      IGT_SPIN_NO_PREEMPTION));
+				    .flags = IGT_SPIN_POLL_RUN);
 		if (ctx)
 			gem_context_destroy(i915, ctx);
 
-- 
2.20.1



More information about the igt-dev mailing list